octokit / octokit.rb

Ruby toolkit for the GitHub API
http://octokit.github.io/octokit.rb/
MIT License
3.83k stars 1.13k forks source link

maint: Added base64 gem explicitly dependency #1658

Closed hsbt closed 5 months ago

hsbt commented 5 months ago

Before the change?

octokit.rb warns the following message With Ruby 3.3.0.

/Users/hsbt/.local/share/gem/gems/octokit-8.0.0/lib/octokit/client/code_scanning.rb:3: warning: base64 was loaded from the standard library, but is not part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of octokit-8.0.0 to add base64 into its gemspec.

This means octokit.rb is not working after Ruby 3.4 release. We should add base64 as dependency.

After the change?

Above warning is suppressed.

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 5 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

hsbt commented 5 months ago

@nickfloyd done to sort alphabetical order.

hsbt commented 5 months ago

Thanks!