DimitriosLisenko
commented
5 months ago Alternatively, could use Faraday::RackBuilder#insert to place the authorization middleware first in the list of handlers, which guarantees it will run before the caching middleware (which is set as part of the Faraday object initialization if the README is followed). Since the authorization middleware just sets some headers, this might be safer to do than rearranging the caching middleware, and it also works if somebody is not using Faraday::HttpCache as their caching middleware.
Resolves #1660
Before the change?
The HTTP caching doesn't have the Authorization header available to it, and therefore caches + returns values across user boundaries.
After the change?
The HTTP caching middleware happens after then authorization middleware, and therefore has the Authorization header and can cache requests per user.
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!