Closed Earlopain closed 4 months ago
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs
. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
1658 added base64 as a dependency in order to supress a warning/error on Ruby 3.3/3.4.
There are two places here where it is used, and these can instead be replaced by the
pack
method which the base64 gem just wraps around.I've instead added it as a development dependency so that tests can continue to make use of it.
Other gems have taken a similar approach:
Before the change?
base64
is part of the depenency tree.After the change?
base64
is removed.Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!