fix: Use auto pagination when retrieving environments

octokit / octokit.rb

Ruby toolkit for the GitHub API

http://octokit.github.io/octokit.rb/

MIT License

3.84k stars 1.13k forks source link

fix: Use auto pagination when retrieving environments #1673

Closed pedrocarrico closed 6 months ago

pedrocarrico commented 7 months ago

Before the change?

Listing environments would only fetch the first page if auto_paginate is set to true.

After the change?

Listing environments will fetch all the pages if auto_paginate is set to true.

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[X] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

github-actions[bot] commented 7 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

pedrocarrico commented 6 months ago

My pleasure @nickfloyd , keep up the good work!