octokit / octokit.rb

Ruby toolkit for the GitHub API
http://octokit.github.io/octokit.rb/
MIT License
3.83k stars 1.13k forks source link

Add GHES Manage API client #1688

Closed manue1 closed 3 weeks ago

manue1 commented 1 month ago

Adds octokit.rb support for GHES Manage API endpoints.

Given that the GHES Manage API going forward will be the only supported API for managing GHES instances we have added support for endpoints that up until now were part of the Management Console API (see its deprecation notice here).


Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 1 month ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

alejndr0 commented 1 month ago

Hey @manue1 thanks for the changes here and apologies for the delay on getting a review out to you. ❤️ These changes look good overall, there is one change to the console message produced from the Faraday check - have a look at what I am proposing and let me know what you think.

Hey nick! Please do not merge this PR yet, just been notified I need to make a quick modification, but I will not be able to do it until Friday :)

alejndr0 commented 1 month ago

@nickfloyd Ready to go 👍🏻

nickfloyd commented 4 weeks ago

@alejndr0 Thx for the updates... I am looking at this now and will get it reviewed and hopefully released this morning.