octokit / octokit.rb

Ruby toolkit for the GitHub API
http://octokit.github.io/octokit.rb/
MIT License
3.83k stars 1.13k forks source link

feat: adds support for Code scanning endpoints #1695

Closed DanBradbury closed 3 weeks ago

DanBradbury commented 1 month ago

Resolves #1694


Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 1 month ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

DanBradbury commented 1 month ago

@nickfloyd - not sure the proper way to request a CR from the maintainers on this one to make sure I'm not going off the deep end.

Was hoping I followed the structure of other modules + the 2 endpoints added before my change.

nickfloyd commented 3 weeks ago

@nickfloyd - not sure the proper way to request a CR from the maintainers on this one to make sure I'm not going off the deep end.

Was hoping I followed the structure of other modules + the 2 endpoints added before my change.

Hety @DanBradbury Thank you for the changes here ❤️. We do our best to try to get things like this reviewed quickly in light of our process. We're a small team of two responsible for about 80 repos so things can get backed up a bit. Apologies for the delay.

Great work here, would you mind addressing the linting issues? Then I'd be glad to get this out the door!

DanBradbury commented 3 weeks ago

Thank you for the CR! @nickfloyd

I've fixed the remaining rubocop issues and pushed it up