search

octokit / octokit.rb

Ruby toolkit for the GitHub API
http://octokit.github.io/octokit.rb/
MIT License
3.84k stars 1.13k forks source link

feat: Add Ruby 3.3 as supported one. #1696

Closed simi closed 3 months ago

simi commented 4 months ago

Add latest Ruby 3.3 to CI and README.md. Is it time to remove EOL Rubies as well and push major version? I can submit additional PR if welcomed.

Btw. any idea what's with logo in README.md and why https://octokit.github.io/octokit.rb/ is outdated?

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

nickfloyd commented 3 months ago

Btw. any idea what's with logo in README.md and why https://octokit.github.io/octokit.rb/ is outdated?

Hey @simi Thanks for the changes here ❤️

As far as the logo goes, it's referencing the docs site which is the old way that we referenced the Gundam Cat. It needs to be updated.

As far as the docs go, this is unfortunately another relic of the past. We haven't generated those docs using yard for about 5 years now. Given we are a small team that is moving toward Generative SDKs the meta needs of some of our older SDKs have simply been deprioritized so that we can focus our efforts on the future.

Please feel free to tackle the out of date docs problem if you'd like and we'd be glad to get it reviewed. I've created an up for grabs issue here if you are interested!