Open pbstriker38 opened 1 month ago
👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs
. You & others like you are the reason all of this works! So thank you & happy coding! 🚀
Describe the need
It would be nice if
auto_paginate
would allow enumeration so that you could stop the request once you have reached your desired goal. Callingto_a
on the enumerator will give you the currentauto_paginate
behavior of just paging to the last page. This avoids wasted requests and memory bloat when potentially concat'ing 10's of thousands of objects with the current auto pagination.Sample code of how it would work
I'm not sure what to do about methods like this one that are returning the total count. This
total_count
is actually wrong when auto paginating since thetotal_count
already takes into account all of the pages. So maybe that should be removed since it is giving the wrong value anyways.SDK Version
No response
API Version
No response
Relevant log output
No response
Code of Conduct