search

octokit / openapi-types.ts

Generated TypeScript definitions based on GitHub's OpenAPI spec
MIT License
37 stars 10 forks source link

[BUG]: Rest Endpoint /orgs/{org}/copilot/billing has not the right typing #394

Closed Uzlopak closed 4 months ago

Uzlopak commented 4 months ago

What happened?

github updated the openapi specification for GET /orgs/{org}/copilot/billing https://github.com/github/rest-api-description/pull/3428

I would like to use the correct type of te response.

Could you please update the package and release it?

@wolfy1339 @gr2m

Versions

-

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 4 months ago

It's because the update script is failing on octokit/openapi die to GHES 3.12 release https://github.com/octokit/openapi/actions/runs/8004107015/job/21860820785

Uzlopak commented 4 months ago

Indeed. How can we fix this? add 3.11 and 3.12 to the supported list? If I do so locally, 3.7 gets removed.

wolfy1339 commented 4 months ago

That's fine for 3.7, it's EOL. Remove all its files and make a breaking change

And yeah, it would simply involve adding 3.11 and 3.12 to the list

Uzlopak commented 4 months ago

@wolfy1339

done

https://github.com/octokit/openapi/pull/418

wolfy1339 commented 4 months ago

Should be released everywhere now

Uzlopak commented 4 months ago

thank you