octokit / plugin-rest-endpoint-methods.js

Octokit plugin adding one method for all of api.github.com REST API endpoints
MIT License
113 stars 54 forks source link

fix(deps): pin @octokit/core peerDependency to v5 #720

Closed DanCurryy closed 6 months ago

DanCurryy commented 6 months ago

Resolves https://github.com/octokit/plugin-rest-endpoint-methods.js/issues/717


Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 6 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 6 months ago

@gr2m @nickfloyd The branch protection rules aren't valid for this branch. I feel like it's matching some generic v*.* matcher and including some workflows that haven't been here for a while

kfcampbell commented 6 months ago

@wolfy1339 I've removed the invalid branch protection checks for the *.x branch protection rule. There are some other 1.x through 6.x rules as well, but hopefully those are far enough back in history they won't be relevant for us. Please let me know if you'd like more changes here!

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 10.4.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: