fix(pkg): add a `default` fallback export

wolfy1339 commented 5 months ago

Resolves octokit/core.js#667 Resolves octokit/core.js#665 Partly reverts #719

Before the change?

Some consumers of this package could not resolve it properly (ex: jest, ts-node, tsx)
CJS consumers would be getting errors even though the package is ESM

After the change?

Clients should be able to import the module without any errors with the fallback
CJS consumers will generate a better error with the new fallback

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

github-actions[bot] commented 5 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 13.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

marekdedic commented 5 months ago

Hi, sorry, I think there is a typo in there - doesn't work for me (unlike all the other @octokitbot packages). PR incoming.

octokit / plugin-rest-endpoint-methods.js