[BUG]: Property 'POST /repos/{owner}/{repo}/pages/deployment' does not exist on type 'Endpoints'.

austenstone commented 5 months ago

What happened?

https://github.com/austenstone/copilot-usage/blob/main/package.json

https://github.com/austenstone/copilot-usage/blob/main/package-lock.json

Versions

5.16.2 5.13.0 10.0.0 10.2.0

Relevant log output

> tsc && ncc build src/index.ts -o dist --source-map --license LICENSE

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:2527:55 - error TS2339: Property 'POST /repos/{owner}/{repo}/pages/deployment' does not exist on type 'Endpoints'.

2527             parameters: RequestParameters & Endpoints["POST /repos/{owner}/{repo}/pages/deployment"]["parameters"];
                                                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:2528:33 - error TS2339: Property 'POST /repos/{owner}/{repo}/pages/deployment' does not exist on type 'Endpoints'.

2528             response: Endpoints["POST /repos/{owner}/{repo}/pages/deployment"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Found 2 errors in the same file, starting at: node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:2527

Code of Conduct

[x] I agree to follow this project's Code of Conduct

github-actions[bot] commented 5 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 5 months ago

This is not a problem with our code. you can't reliably mix multiple versions of Octokit together.

This is due to differing versions of @octokit/types and @octokit/openapi-types which contain all endpoints

wolfy1339 commented 5 months ago

This is due to https://github.com/actions/toolkit/blob/main/packages/artifact/package.json and https://github.com/actions/toolkit/blob/main/packages/github/package.json

octokit / plugin-rest-endpoint-methods.js