search

octokit / request-action

A GitHub Action to send arbitrary requests to GitHub's REST API
https://github.com/marketplace/actions/GitHub-API-Request
MIT License
369 stars 48 forks source link

PRs are mergeable with check runs failing and no approvals in this repository #158

Closed oscard0m closed 2 years ago

gr2m commented 2 years ago

That's because part of the release is a git push to the default branch. We would need to use an admit PAT if we were to enable branch protections for the *-action repositories.

oscard0m commented 2 years ago

So the steps would be:

  1. Replace GITHUB_TOKEN in release.yml

    env:
-         GITHUB_TOKEN: ${{ secrets.GR2M_PAT_FOR_SEMANTIC_RELEASE }}
+         GITHUB_TOKEN: ${{ secrets.OCTOKITBOT_PAT }}

  2. Enable branch protection settings in the repository.

Is this correct?

Is secrets.OCTOKITBOT_PAT available at Org level?

gr2m commented 2 years ago

we would need to make @octokitbot an admin in this repo, but maybe that's the simplest solution, let's do it 👍🏼 I'll update the repository settings, can you update release.yml? Let's do the same for https://github.com/octokit/graphql-action

octokitbot commented 2 years ago

:tada: This issue has been resolved in version 2.1.6 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: