search

octokit / request-action

A GitHub Action to send arbitrary requests to GitHub's REST API
https://github.com/marketplace/actions/GitHub-API-Request
MIT License
363 stars 48 forks source link

> I see some repositories using `npm run build` #259

Closed najmulsheik closed 12 months ago

najmulsheik commented 12 months ago 
          > I see some repositories using `npm run build`

I'd always run it with npm run build --if-present, just like the others. This makes sure that we verify that the dependencies only used for building are tested as part of the CI

  • npm run validate:ts
  • npm run test:typescript
  • npm run test:ts

I'm tending towards test:tsc to be as clear as possible. In other project I use test:tsd for type-only tests using tsd, and in future when I hope me move away from TS source code I could imagine @octokit to use that, too (Example)

But I'm open to anything, it's not set in stone. I do agree we should normalize it across the @octokit repositories though

Originally posted by @gr2m in https://github.com/octokit/.github/issues/13#issuecomment-1200523926

kfcampbell commented 12 months ago

This seems off-topic/potentially spam, closing for that reason.