search

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node
MIT License
228 stars 60 forks source link

[BUG]: Network errors from unidici are not properly surfaced #641

Closed nikhilgupta345 closed 12 months ago

nikhilgupta345 commented 12 months ago

What happened?

Undici surfaces network errors as type errors with the actual error under cause. This presents all network errors as "fetch failed" rather than showing the actual error.

Versions

All versions of Octokit

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 12 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] commented 12 months ago

:tada: This issue has been resolved in version 8.1.3 :tada:

The release is available on:

Your semantic-release bot :package::rocket: