Add permissions - Githubissues

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node

MIT License

224 stars 61 forks source link

Add permissions #669

Closed jsoref closed 5 months ago

jsoref commented 5 months ago

Resolves #668

Before the change?

Error: Input required and not supplied: github-token
Error: Resource not accessible by integration

After the change?

stale-bot will be annoying in forks
codeql will work in paranoid forks

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

github-actions[bot] commented 5 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 5 months ago

Can you make the changes to the add to octokit project workflow in https://github.com/octokit/.github/blob/main/.github/templates/add_to_octokit_project.yml instead

jsoref commented 5 months ago

@wolfy1339: done

wolfy1339 commented 5 months ago

It would probably be nice to go across the Octokit repos and do the same changes

wolfy1339 commented 5 months ago

It seems this has introduced unintended issues. The release workflow is failing with the same error that you got that led to this PR

jsoref commented 5 months ago

Oh, that one probably needs contents: write -- I misguessed how the workflow worked.

jsoref commented 4 months ago

It would probably be nice to go across the Octokit repos and do the same changes

I'd probably eventually do this as I run into a need to contribute to them. Or I might do it as a batch. Given how quickly you responded to this series, I'm more inclined to do it.