search

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node
MIT License
224 stars 61 forks source link

[BUG]: `release.yml` needs `contents: write` #672

Closed jsoref closed 4 months ago

jsoref commented 4 months ago

What happened?

The merge of #669 removed too many permissions and broke the release workflow: https://github.com/octokit/request.js/actions/runs/7844069059/job/21405658705

Versions

HEAD

Relevant log output

> [12:39:06 PM] [semantic-release] › ✘  The command "git push --dry-run --no-verify https://x-access-token:[secure]@github.com/octokit/request.js.git HEAD:main" failed with the error message remote: Permission to octokit/request.js.git denied to github-actions[bot].

Code of Conduct

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 4 months ago

There are probably others that need write permissions

jsoref commented 4 months ago

I'm optimistic that there aren't... I think the act of creating the release and creating this issue and the pr for it would exercise almost everything.

The exception being prettier which is disabled.

prettier indeed doesn't work on forks, but that isn't a change: https://github.com/jsoref/request.js/actions/runs/7844368925