octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node
MIT License
228 stars 60 forks source link

ci(workflows): add write permissions to release workflow #673

Closed jsoref closed 7 months ago

jsoref commented 7 months ago

Resolves #672


Before the change?

After the change?

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!


github-actions[bot] commented 7 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

jsoref commented 7 months ago

Actually, it apparently needs more than that...

jsoref commented 7 months ago

Ok, w/ those two permissions, my fork is able to get a ✅ https://github.com/jsoref/request.js/actions/runs/7844257545.

And boy it is so much nicer with the changes integrated -- figuring out what's missing is trivial! Now I just need to get everyone to upgrade.