search

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node
MIT License
224 stars 61 forks source link

ci(workflows): enable prettier for forks #675

Open jsoref opened 4 months ago

jsoref commented 4 months ago

Resolves #674

Before the change?

After the change?

Note: The configuration has a PAT... There are a whole bunch of ways to make this work, but this seems simplest... One could just remove the PAT, or I could add some really complicated code to check to see if there is a PAT and if there is a PAT do one thing and then if not, do the other... But, I don't see the point.

I'm also upgrading the node version to 20 since this package.json is 20 and it seems like a bad idea to run linters w/ the wrong version of node -- the prettier workflow is disabled in this repository and I wonder if that's one of the reasons it is...

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

jsoref commented 4 months ago

https://github.com/jsoref/request.js/actions/runs/7844488288 created

jsoref commented 4 months ago

There's an even fancier hack that would involve a reusable workflow and two jobs that would call it with the available item. But I'm not an expert in using reusable workflows. If this workflow was a lot more complicated, that'd probably be warranted.