feat: switch to ESM output

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node

MIT License

224 stars 61 forks source link

feat: switch to ESM output #678

Closed wolfy1339 closed 4 months ago

wolfy1339 commented 4 months ago

BREAKING CHANGE: Output a single ESM bundle

github-actions[bot] commented 4 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 4 months ago

The types for the Fetch API don't allow headers to be passed as numbers, only as string. The docs also mention this https://developer.mozilla.org/en-US/docs/Web/API/Headers/Headers#init

I added a conversion since we accept numbers

wolfy1339 commented 4 months ago

There's some funkyness going on with fetch-mock... It's complaining about "Unmatched GET"/ "No fallback response defined for GET to [..]"