search

octokit / request.js

Send parameterized requests to GitHub’s APIs with sensible defaults in browsers and Node
MIT License
224 stars 61 forks source link

potential bug: native fetch not throwing errors? #699

Open Uzlopak opened 1 week ago

Uzlopak commented 1 week ago

I have a bug in the production where a 404 response is not throwing accordingly.

Very strange behaviour. For this I am currently proposing PRs which make it easier for me to investigate the bug. I have the strong feeling that there is a bug in this repo, and it is not showing properly because we mock the fetch calls.

github-actions[bot] commented 1 week ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

gr2m commented 6 days ago

I have a bug in the production where a 404 response is not throwing accordingly.

Is your code using vanilla @octokit/core or some higher level library?

is it for an installation access token? I think @auth/app-token does retry 404s due to a possible replication lag

Uzlopak commented 6 days ago

I use probot.

Maybe something wrong with google cloud functions framework.

Uzlopak commented 3 hours ago

Somewhere in our code, it seems that the status code of the Response object is a string! Atleast when we use GCF. Very strange