search

octokit / source-generator

Generates SDKs from GitHub's OpenAPI specification. Built on Kiota.
8 stars 3 forks source link

Hack: VersionsRequestBuilder errors #23

Closed kfcampbell closed 10 months ago

kfcampbell commented 11 months ago

This code

https://github.com/octokit/source-generator/blob/e8fa980b3e4653b4f355147c595f454943984b30/post-processors/go/main.go#L122

is there to fix the following build error (when it is removed): 

+ go build ./...
# github.com/octokit/kiota/versions
versions/versions_request_builder.go:53:24: impossible type assertion: v.(*i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.DateOnly)
    *serialization.DateOnly does not implement serialization.Parsable (missing method GetFieldDeserializers)

This hack as implemented breaks functionality, so we should take this to the Kiota team and see if they can help point us in the right direction.

baywet commented 11 months ago

Hey 👋 For this one, can you open an issue in kiota's main repository with a repo description section please? I'm afraid that we made an assumption in the generation for serialization/deserialization with DateOnly arrays that somehow doesn't work in your context.

kfcampbell commented 11 months ago

Done! See https://github.com/microsoft/kiota/issues/3679.