search

octokit / source-generator

6 stars 3 forks source link

Auto-update the dotnet SDK #44

Closed kfcampbell closed 7 months ago

kfcampbell commented 7 months ago

This PR uses the gr2m/create-or-update-pull-request-action@cd-path Action to autogenerate commits to the octokit/dotnet-sdk repo.

kfcampbell commented 7 months ago

@nickfloyd do you mind sharing the versions of .NET, Go, and Kiota you used to create the initial commit of the dotnet-sdk? I can reproduce these build errors locally.

kfcampbell commented 7 months ago

Ahh, I got it working locally. Builds should succeed with a version bump for Kiota's helpers, done in https://github.com/octokit/dotnet-sdk/pull/2.

In the future, we should do something for .NET like we do for Go in post-processing, where the latest versions of the helpers are always installed. That way, the helper package versions will keep updated in lockstep with Kiota versions and we can ensure compatability.

kfcampbell commented 7 months ago

Woohoo! The build is now successful and https://github.com/octokit/dotnet-sdk/pull/3 has been created for the changes. I'm going to publish this PR now.

@nickfloyd when you review, do you mind double-checking the namespacing? I may have messed something up, I'm seeing this in the diff:

- namespace GitHub.Octokit.Advisories {
+ namespace Octokit.Client.Advisories {

Maybe that's expected?