search

octokit / source-generator

6 stars 3 forks source link

maint: Creates pr diff script to help analyze the impact of generated SDK PRs #53

Closed nickfloyd closed 3 months ago

kfcampbell commented 3 months ago

Note that when run against https://github.com/octokit/go-sdk/pull/57, this script prints a blank commit message: 

Commit message: FEAT:
Added lines: 7
Removed lines: 5

The script is failing to capture the addition of "406": i59ea7d99994c6a4bb9ef742ed717844297d055c7fd3742131406eea67a6404b6.CreateBasicErrorFromDiscriminatorValue, for some reason, which is interesting.

kfcampbell commented 3 months ago

When attempting to fetch https://github.com/octokit/dotnet-sdk/pull/55, it simply prints Failed to fetch PR diff. and returns, perhaps because it's not equipped to handle changes of the scale of the PR (2277 files changed at the time of writing).

nickfloyd commented 3 months ago

Note that when run against octokit/go-sdk#57, this script prints a blank commit message:

Commit message: FEAT:
Added lines: 7
Removed lines: 5

The script is failing to capture the addition of "406": i59ea7d99994c6a4bb9ef742ed717844297d055c7fd3742131406eea67a6404b6.CreateBasicErrorFromDiscriminatorValue, for some reason, which is interesting.

Interesting... I'll need to drop an issue in the repo to have a look at later. No idea why these two things would be happening.