search

octokit / webhooks.js

GitHub webhook events toolset for Node.js
MIT License
317 stars 79 forks source link

[FEAT]: WebStandard Middleware #1063

Open akku1139 opened 1 month ago

akku1139 commented 1 month ago

Describe the need

Currently, octokit only supports creating middleware for Node.js , but there are times when I want to use octokit in an environment other than Node.js . This is not a big problem with runtimes that are compatible with Node.js, such as Deno and Bun, Edge runtimes such as Cloudflare Workers may not offer Node.js compatibility. Therefore, it is necessary to provide Middleware that uses WebStandard API (Request/Response).

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 1 month ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

wolfy1339 commented 1 month ago

I created this middleware, https://github.com/octokit/webhooks.js/compare/web-middleware

akku1139 commented 1 month ago

app.js and oauth-app.js also need to be supported in the same way.

It was already supported in oauth-app.js

https://github.com/octokit/oauth-app.js/blob/main/src/middleware/web-worker/index.ts