search

octokit / webhooks.net

GitHub webhook events toolset for .NET
MIT License
52 stars 32 forks source link

[FEAT]: support native AOT #408

Open JamieMagee opened 11 months ago

JamieMagee commented 11 months ago

Describe the need

https://devblogs.microsoft.com/dotnet/creating-aot-compatible-libraries/

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 11 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

github-actions[bot] commented 2 months ago

👋 Hey Friends, this issue has been automatically marked as stale because it has no recent activity. It will be closed if no further activity occurs. Please add the Status: Pinned label if you feel that this issue needs to remain open/active. Thank you for your contributions and help in keeping things tidy!

martincostello commented 1 month ago

I'm not against the idea of picking this up myself as the lack of AoT support here prevents me using AoT in one of my apps, but it's probably going to be quite a big change to do properly (using the JSON source generator, flowing the relevant context around etc.).

Any guidelines about how you'd want this change approached before doing any actual work trying to make it happen?

JamieMagee commented 1 month ago

I've been deferring this issue until kiota publishes a release with support for OpenAPI 3.1, which includes support for webhooks. Kiota appears to be blocked waiting for a new release of OpenAPI.NET, but that seems pretty close: https://github.com/microsoft/OpenAPI.NET/issues/1607#issuecomment-2368768550