search

octokit / webhooks.net

GitHub webhook events toolset for .NET
MIT License
48 stars 30 forks source link

feat: return IEndpointConventionBuilder from MapGitHubWebhooks to allow additional configuration of endpoint #477

Closed omccully closed 2 months ago

omccully commented 3 months ago

Allows additional configuration of endpoint. For example, allowing anonymous access for the endpoint for an app that otherwise requires a specific type of authentication: app.MapGitHubWebhooks("/api/github/webhooks, githubWebhookSecret).AllowAnonymous()

Resolves #476

Before the change?

If you have authentication on your entire app but you want to allow anonymous access to the GitHub webhook endpoint, there doesn't seem to be a way to do that currently.

After the change?

The IEndpointConventionBuilder is available to users of the library, so they can configure any of the settings that you normally could for a app.MapPost( ... ) call, including AllowAnonymous().

Pull request checklist

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

github-actions[bot] commented 3 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀