Polymorphic custom property values (fixes deserialization bug)

colbylwilliams commented 2 weeks ago

Resolves #520

Before the change?

Custom Property and Custom Property Value schemas added new value_types and updated the default_value and value properties to allow for null, string, or array. This breaks deserialization of payloads with Custom Property or Custom Property Values. See issue for more details.

After the change?

Added multi_select, and true_false custom property value types
Custom Property definition default_value may be null, string, or array of strings
Custom Property value property may be null, string, or array of strings
Updated Repository.CustomProperties to be IDictionary<string, object> to support polymorphic values of either string or array

Pull request checklist

[x] Tests for the changes have been added (for bug fixes / features)
[x] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[ ] Yes
[x] No

github-actions[bot] commented 2 weeks ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

colbylwilliams commented 1 week ago

cc: @JamieMagee

octokit / webhooks.net