search

octokit / webhooks.net

GitHub webhook events toolset for .NET
MIT License
48 stars 30 forks source link

[BUG]: Inconsistent types on WebHook models #524

Open ilmax opened 2 days ago

ilmax commented 2 days ago

What happened?

Different types exposes similar properties using different underlying types, I was looking at the *_at properties in the class WorkflowJob and seems like those properties are exposed as string while most of the time they're exposes as DateTimeOffset.

Having a quick look here I found some more occurrences here and here

Can we unify those and use DateTimeOffset everywhere? This will be a breaking change so it requires a major version bump.

Versions

2.2.2

Relevant log output

No response

Code of Conduct

github-actions[bot] commented 2 days ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

JamieMagee commented 2 days ago

@ilmax thanks for opening the bug. I think #525 resolves this, but I agree that this is a breaking change. I'll see if we have any more immediate breaking changes that we want to batch together into a 3.0.0 release.

ilmax commented 2 days ago

Looking forward to version 3 soon then, thank you for the quick fix!