Use `DateTimeOffset` everywhere instead of `string`

octokit / webhooks.net

GitHub webhook events toolset for .NET

MIT License

51 stars 32 forks source link

Use `DateTimeOffset` everywhere instead of `string` #525

Closed JamieMagee closed 2 months ago

JamieMagee commented 3 months ago

Resolves #524

Before the change?

An inconsistent mix of string and DateTimeOffset for *_at fields.

After the change?

Use DateTimeOffset everywhere instead of string

Pull request checklist

[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

[x] Yes
[ ] No

github-actions[bot] commented 3 months ago

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

ilmax commented 2 months ago

Hey @JamieMagee, anything blocking this PR?

JamieMagee commented 2 months ago

@ilmax I cut this as v3.0.0