search

octoper / statamic-html-minify

5 stars 4 forks source link

Don't minify if response is instance of StreamedResponse #6

Closed duncanmcclean closed 3 years ago

duncanmcclean commented 3 years ago

This pull request fixes #5, where when using Glide to generate images, it would return a StreamedResponse instance which would end up throwing an exception.

duncanmcclean commented 3 years ago

Also noticed your tests are failing due to a namespace issue. Anyways, glad you used my addon boilerplate 😅

octoper commented 3 years ago

Thanks for the PR! I know about the test wanted to fix it but I haven't found any time, might do it today 😬 I'm glad you made that boilerplate 😅