search

octopitus / rn-sliding-up-panel

Draggable sliding up panel implemented in React Native https://octopitus.github.io/rn-sliding-up-panel/
MIT License
928 stars 157 forks source link

hide() with draggableRange bottom won't hide the panel completely #155

Open nirjack opened 4 years ago

nirjack commented 4 years ago

Issue Description

hide() with draggableRange bottom wont hide the panel completely

Steps to Reproduce / Code Snippets / Screenshots

_panel.hide() doesn't hide the draggableRange bottom, Can hide method take parameters like hide(0) -> to completely hide the panel

Environment

octopitus commented 4 years ago

If you have draggableRange's bottom is a number larger greater than 0. Then it's not likely you can go below that number.

Perhaps the function name hide is not correct in this case.

tayguohong commented 4 years ago

If you have draggableRange's bottom is a number larger greater than 0. Then it's not likely you can go below that number.

Perhaps the function name hide is not correct in this case.

But I found a strange behaviour when hide function is called in android device. The panel does not return to the draggableRange's bottom number. It is closed some where in the middle on the screen. But in IOS, I have no issue.

I found a temporary solution in android, which is called hide function twice to make sure it is hidden to initial position. But I hope you can look into this issue.