search

octopitus / rn-sliding-up-panel

Draggable sliding up panel implemented in React Native https://octopitus.github.io/rn-sliding-up-panel/
MIT License
929 stars 157 forks source link

Fix currentlyFocusedField deprecation error #193

Closed jrapala closed 3 years ago

jrapala commented 3 years ago

#191 still seems to be an issue on v.2.4.4 with React Native 0.63.3

As it stands, currentlyFocusedField still exists, but is deprecated, so the warning will always show. This PR checks if the new currentlyFocusedInput exists first, and falls back to the deprecated currentlyFocusedField if it does not.

Also findNodeHandler does not exist. Should be findNodeHandle.

Screen Shot 2020-11-17 at 2 35 14 PM
joepake commented 3 years ago

@octopitus please review this PR. Many thanks

mwerder commented 3 years ago

@octopitus can you please release this soon?

jrapala commented 3 years ago

@octopitus I would like a release as well :)

octopitus commented 3 years ago

@mwerder @jrapala Updated in 2.4.5. Sorry for the delay.