octopitus / rn-sliding-up-panel

Draggable sliding up panel implemented in React Native https://octopitus.github.io/rn-sliding-up-panel/
MIT License
928 stars 157 forks source link

allowDragging not working #90

Closed gfsd3v closed 5 years ago

gfsd3v commented 5 years ago

Issue Description

For some reason the allowDragging props isn't blocking the drag of the panel, I read the documentation and from my understand I'm passig the props correctly.

This is the render function from my component

  render() {
    return (
      <SlidingUpPanel
        allowDragging={false}
        animatedValue={_animatedValue}
        ref={c => (this._panel = c)}
        draggableRange={{ top: WINDOW.height - 46, bottom: 0 }}
      >
          <View style={styles.container}>
            <View style={{ flex: 1, marginBottom: 40 }}>
              {this.props.children}
            </View>
          </View>
      </SlidingUpPanel>
    );

Environment

octopitus commented 5 years ago

@4rtikk Thanks for reporting this. My fault, probably. Can you try again with version 2.0.0-rc4?

gfsd3v commented 5 years ago

Sorry for the delay, I ended up using the current stable version, but I'll test it today and I get back to you.

// Edit: Working fine for the 2.0.0-rc4 version, thanks :)