search

octoposprime / op-be-graphql

OctopOS Prime Backend Api Gateway
http://www.octoposprime.com
MIT License
13 stars 1 forks source link

Add 'ErrorDlrNotFound' to errors #86

Closed mervegonc closed 3 months ago

mervegonc commented 3 months ago

Closes #51 Add 'ErrorDlrNotFound' to errors

Sddilora commented 3 months ago

D'accord S'il vous plaît Corrigez Le Titre De La Demande de tirage (pull request)

mervegonc commented 3 months ago

"But the return value is correct this time." 👍🏻

thanks to you <3

mervegonc commented 3 months ago

D'accord S'il vous plaît Corrigez Le Titre De La Demande de tirage (pull request)

Do you comment when you are bored, in french?

Sddilora commented 3 months ago

Our title needs to describe what we have done in this PR. "dlr add err" might refer to any error on DLR, so it could mean several things a month later, leading to potential trouble in managing our previous processes. We need to choose a more descriptive name, such as "Add 'ErrorDlrNotFound' to errors," so that we can understand what we have merged in this PR not only now but also a month or even a year later. Thank you for considering this change.

Sddilora commented 3 months ago

D'accord S'il vous plaît Corrigez Le Titre De La Demande de tirage (pull request)

Do you comment when you are bored, in french?

No, I was not bored. I'm sorry, but I got frustrated because we've discussed this problem many times and we're still encountering it. It seems like we're not giving our tasks the attention they deserve, and it puts a lot of pressure on our leads for small matters.