octoposprime / op-be-graphql

OctopOS Prime Backend Api Gateway
http://www.octoposprime.com
MIT License
13 stars 1 forks source link

Makefile Fixing for Docker #9

Closed Sddilora closed 5 months ago

Sddilora commented 6 months ago

We need to update the parameters and commands in the Makefile to align with the values in the .env file.

We also need to add the following to the Makefile:

POSTGRES_USERNAME?=op#Postgres Db User Name
POSTGRES_PASSWORD?=op#Postgres Db Password
JWT_SECRET_KEY?=op#Jwt Secret Key
REDIS_PASSWORD?=op#Redis Password

Additionally, we need to modify the docker-build section in the Makefile as follows:

## Docker:
docker-build: ## Use the Dockerfile to build the container
    docker build --rm --tag $(DOCKER_REPOSITORY)/$(DOCKER_CONTAINER) \
    --build-arg TEST=$(TEST) \
    --build-arg POSTGRES_USERNAME=$(POSTGRES_USERNAME) \
    --build-arg POSTGRES_PASSWORD=$(POSTGRES_PASSWORD) \
    --build-arg JWT_SECRET_KEY=$(JWT_SECRET_KEY) \
    --build-arg REDIS_PASSWORD=$(REDIS_PASSWORD) .