octopress / asset-pipeline

Adds your local CSS, Sass, Javascript and Coffeescript files to Octopress Ink's asset pipeline.
MIT License
4 stars 3 forks source link

css_asset_tag doesn't generate the link #3

Closed rbeeger closed 10 years ago

rbeeger commented 10 years ago

I'm using jekyll 2.2.0 octopress 3.0.0.rc.14 octopress-Ink 1.0.0.rc.11 octopress-deploy 1.0.0.rc.10 octopress-asset-pipeline 1.0.1

In the root directory for my blog generator I have a normalize.css and a main.scss _octropress.yml contains

order_css:
  - normalize.css
  - main.scss

After building _site/stylesheets contains all-some sequence of characters.css, but the tag {% css_asset_tag %} that I put into my head.html include only produces a blank line. I'm quite sure that jekyll sees this tag since changing it to {% css_asset_tag_something %} produces an error.

What am I missing?

Cheers, Robert

rbeeger commented 10 years ago

Playing around a bit more with this I found the problem. Since I don't have any javascript I only had

 {% css_asset_tag %}

in my head.html include. Apparently even though there is no javascript to minify, you actually need to include both tags. So with

{% css_asset_tag %}
{% js_asset_tag %}

it actually works as expected. Playing around even further I found out that only having

{% js_asset_tag %}

also does the job. So either css_asset_tag is not needed at all or it will insert the link for the combined javascript if there is any.

imathis commented 10 years ago

Thanks for digging into this. That's totally bizarre. I'll look into it!

imathis commented 10 years ago

I've just released Octopress Ink RC13 which should fix this for you. Thanks for the catch!

rbeeger commented 10 years ago

I understand the fix for this in octopress-ink, but there seems to be another change which leads to https://github.com/octopress/ink/issues/24 .

BTW: Thanks for making Octopress 3. It already looks great.

imathis commented 10 years ago

Oops. Didn't mean to reopen this issue. Thanks for the report, I've just gotten it to reproduce here. Thanks!

imathis commented 10 years ago

@rbeeger Thanks to your issues, I've done a fair bit of refactoring on Octopress Ink and on the asset-pipleline plugin. I've just released two new versions and I'm able to add back support for rendering Liquid inside of Sass files. Thanks again!

rbeeger commented 10 years ago

Just updated. Now it all works. Thanks.