search

octopress / date-format

Automatically adds variables with nicely formated dates and time tags to Jekyll posts and pages.
MIT License
16 stars 13 forks source link

Use correct pluralized words to fix Jekyll Hooks. #9

Open ryanoglesby08 opened 8 years ago

ryanoglesby08 commented 8 years ago

Use correct pluralized words in Jekyll Hooks. Move 'pages' hook to pre_render so that it has time to load the front matter.

Attempting to move my blog over to Octopress 3.0 and found this plugin to be broken with Jekyll 3.1.6 because the Jekyll Hooks integration was not specified correctly. Singular vs plural in the symbols. https://jekyllrb.com/docs/plugins/#hooks

Clash test was broken when I forked it. Fixed the clash expectation in the process. Seems to be passing now.

Hope you can pull this in soon so I can use this plugin. :)

parkr commented 8 years ago

This will require Jekyll 3.0, I believe.

ryanoglesby08 commented 8 years ago

Ahhh, hmmmmm. So would you prefer to do a Jekyll version check before registering the hooks, splitting the code paths for v2.x.x and v3.x.x? Or changing the runtime dependency of this plugin to >= Jekyll 3? The latter would probably cause a major version bump too I suppose.

parkr commented 8 years ago

Jekyll 2 has been retired, so I'd personally rather see this move forward as Jekyll 3 only. That said, I'm not sure what @imathis has in mind for compatibility. :)