octopress / deploy

Deployment for Octopress and Jekyll blogs.
MIT License
75 stars 23 forks source link

Boolean options in _deploy.yml don't seem to work #42

Closed fehwalker closed 9 years ago

fehwalker commented 9 years ago

While looking at issue #41 I was trying to add a config file boolean to enable/disable the feature in _deploy.yml, and after a lot of testing I discovered the functionality is generally broken.

For example, if you set verbose to false in _deploy.yml it still prints verbose output.

fehwalker commented 9 years ago

The issue is that initialization of the verbose variable always results in it being true.

I believe the only relatively easy way to handle this is to have all booleans default to false unless explicitly set to true in the config, like the delete variable already is.

In the specific case of the verbose setting it's more consistent with general best practices anyway to have it default to off if not set. I'm going to put together a change to do this. I'll make sure the example initial config will still have it set to true.

fehwalker commented 9 years ago

I think this can be closed now.

imathis commented 9 years ago

Yep! You can try out 1.0.5 now and let me know if it goes well for you.

fehwalker commented 9 years ago

Yep, looks good, thanks!