search

octopress / deploy

Deployment for Octopress and Jekyll blogs.
MIT License
75 stars 23 forks source link

Fixed the S3 deploy #50

Closed FlorinAsavoaie closed 9 years ago

FlorinAsavoaie commented 9 years ago
  1. It appears like the gem is using the aws-sdk-v1 but the dependency is not specific so I got v2 installed which uses a different namespace. Adjusted the gemspec and the require gem name, as well as the README.md to specify the correct gem to install.
  2. I am not sure how this gem ever worked to upload new files to Amazon S3, at least with the aws-sdk-v1 version I have. For me, it kept failing with a "No Such Key" exception raised by the AWS SDK. Added a rescue for that specific error to upload the file if it does not already exist in S3.
magikid commented 9 years ago

I found the same problem. I think the key does not exist error comes up when the file isn't already in S3. AWS can't return the hash of the file in o.etag

imathis commented 9 years ago

Thanks!