require higher sass version

octopress / genesis-theme

A Jekyll theme build on Octopress Ink

MIT License

24 stars 16 forks source link

require higher sass version #27

Closed darix closed 9 years ago

darix commented 9 years ago

3.2.19 wasnt enough to render the files part of octopress/this theme. sass 3.4.13 on the other hand worked.

lukaszklis commented 9 years ago

It's a dependency inherited from https://github.com/jekyll/jekyll-sass-converter/blob/master/jekyll-sass-converter.gemspec. After cloning the repository and running bundle, it installed sass in 3.4.13:

➜  genesis-theme git:(master) bundle
Fetching gem metadata from https://rubygems.org/..........
Resolving dependencies...
...
Installing sass 3.4.13

darix commented 9 years ago

gem install --conservative and not everyone is using bundler either. our rubygem rpms are honoring dependencies. and in this case 3.2 was enough but it is actually a non working version. as such the dependency should be bumped. also while jekyll-sass-convert is correct with ~> 3.2 because i could write 3.2 compatible code. the code in this theme isnt. as such it should require a newer sass version.

imathis commented 9 years ago

I just released version 0.0.9 which addresses this issue and bumps the Sass dependency up to 3.4. Thanks!

darix commented 9 years ago

On 2015-04-07 13:25:46 -0700, Brandon Mathis wrote:

I just released version 0.0.9 which addresses this issue and bumps the Sass dependency up to 3.4. Thanks!

Thank you. Updating my rpm.

darix

       openSUSE - SUSE Linux is my linux
           openSUSE is good for you
               www.opensuse.org