search

octopress / include-tag

A powerful include tag with conditional rendering, filters, and more.
MIT License
2 stars 6 forks source link

v1.1.2 breaks parameters in includes #2

Closed maiertech closed 9 years ago

maiertech commented 9 years ago

I noticed that v1.1.2 breaks includes with parameters. The includes work, but parameters are nil when accessed within the includes. I verified that with v1.1.1 everything works fine.

imathis commented 9 years ago

Oof! thanks for the report. I'll see if I can get that fixed.

imathis commented 9 years ago

Which version of Jekyll are you using?

maiertech commented 9 years ago

Jekyll v2.5.3.

imathis commented 9 years ago

This test passes fine. Are you using vars in a different way? Could you show provide a test case that I can get a failure on?

maiertech commented 9 years ago

Can you add a test case where you pass in as parameter a liquid variable and not a string? I have this include:

{% include theme:dry/navigation-list.html id="navigation-list" category=category %}

In v1.1.2 the id gets passed in but the category not, even though it is set.

imathis commented 9 years ago

I believe this should be fixed now.

maiertech commented 9 years ago

Works. Thanks!