Open dgmstuart opened 7 years ago
Looks like this will also be a problem in multilingual, e.g. https://github.com/octopress/multilingual/blob/master/lib/octopress-multilingual.rb#L130 https://github.com/octopress/multilingual/blob/master/lib/octopress-multilingual.rb#L152
Loads of array-ish operations on posts
in that file.
Issue on Multilingual - possibly related: https://github.com/octopress/multilingual/issues/29
Looking at the code I'm not super confident making a change without some support:
Octopress.site.pages << page
- are they fine, or do they need to use .docs
as well?< 3
, and then a version 2.0 for jekyll >= 3.0.0
?Oops - looks like there's already a PR for this: https://github.com/octopress/ink/pull/66
https://github.com/octopress/ink/blob/master/lib/octopress-ink/plugin/bootstrap.rb#L163
https://github.com/octopress/ink/blob/master/lib/octopress-ink/plugin/bootstrap.rb#L171
I don't super understand the Jekyll code, but this deprecation was introduced when moving from 2.x to 3.x. It seems like there will be a breaking change at some point such that these (enumerable-ish? collection-ish?) methods will no longer be defined on whatever
pages
returns, but instead onpages.docs
.Should be a straightforward fix - I'll have a look.