octopusden / octopus-components-registry-service

Apache License 2.0
0 stars 0 forks source link

Support docker image name configuration #42

Open pgorbachev opened 2 weeks ago

pgorbachev commented 2 weeks ago

1) Support configuration of docker image name for component in the following section

  docker {
      imageName = 'some image name'
  }

2) It should be supported in a)

Defaults {
}

b) component-level c) version range

3) following expressions have to be also supported:

For example, for configuration

"my-service" {
    groupId = "org.octopusden.octopus.system-test"
    docker {
        imageName = '$namespaceFromGroupId/$componentKey'
    }
}

dockerImageName will be 'octopus/system-test/my-service`

  1. dockerImageName should be added to Component model

https://github.com/octopusden/octopus-components-registry-service/blob/main/components-registry-service-core/src/main/kotlin/org/octopusden/octopus/components/registry/core/dto/Component.kt

fishinitself commented 2 weeks ago

@pgorbachev stupid question - if an imageName is just a function of the component ID and the component GAV , why do we need to declare it separately?

pgorbachev commented 2 weeks ago

@pgorbachev stupid question - if an imageName is just a function of the component ID and the component GAV , why do we need to declare it separately?

Different rules including static name of the image have to be supported

aryabokon commented 2 weeks ago

Давайте сделаем версионируемым поле