search

octopush / OctopushSMSBundle

7 stars 11 forks source link

Missing quotes in services configuration #5

Closed Thomson2306 closed 6 years ago

Thomson2306 commented 6 years ago

Hi,

Since Symfony 3, you're supposed to add quotes around scalar values in the services.yml. It actually throws a deprecation waring in the Symfony profiler :

Not quoting the scalar "%octopush_sms.api_key%" starting with the "%" indicator character is deprecated since Symfony 3.1 and will throw a ParseException in 4.0 in vendor/octopush/sms-bundle/DependencyInjection/../Resources/config/services.yml.

The fix is quite easy, simply add quotes around %octopush_sms.user_login% and %octopush_sms.api_key% in the services.yml :

- '%octopush_sms.user_login%' - '%octopush_sms.api_key%'

Thanks ! Thomas

octopush commented 6 years ago

Thanks for your notification. I'll have it added on the repo.

Regards

Thomson2306 commented 6 years ago

Hello,

Thanks for the quick update :) Would it be possible to update the project on Packagist ? (A composer update doesn't show any difference currently)

Thanks a lot, Best regards, Thomas

octopush commented 6 years ago

Bundle has just been updated on Packagist. It should have been done automaticly, but anyway, it has been done manually.

Thanks for your following !

Thomson2306 commented 6 years ago

Perfect, everything is good right now. Thanks for the quick support ! Best regards, and merry christmas :) Thomas