search

octopush / OctopushSMSBundle

7 stars 11 forks source link

TreeBuilder::root()" method is deprecated #9

Open partikule opened 4 years ago

partikule commented 4 years ago

Hello,

Can you update the bundle to fix this depreciation message on Symfony 4.3 ?

The complete message is : The "Symfony\Component\Config\Definition\Builder\TreeBuilder::root()" method called for the "octopush_sms" configuration is deprecated since Symfony 4.3, pass the root name to the constructor instead.

The solution is to rewrite a little the Configuration.php class : 

        if (Kernel::VERSION_ID >= 40200) {
            $treeBuilder = new TreeBuilder('octopush_sms');
        } else {
            $treeBuilder = new TreeBuilder();
            $treeBuilder->root('octopush_sms')
        }
pulsarf0x commented 2 years ago

Good morning,

It seems this issue is fixed since the day you created it. Could we consider this issue is closed ?

Have a nice day, Pascal from Octopush.

partikule commented 3 weeks ago

Wow, it took a little bit time to get an answer :-D Please close it, we forked the package in the mean time and we will test the 2.0 version on Symfony 6.4.