search

octopusthink / ghost-ship

A Gatsby starter template for websites & blogs. Designed for accessibility and SEO-friendliness.
MIT License
2 stars 0 forks source link

feat: Show footer copyright line in site footer. #37

Closed sarahmonster closed 4 years ago

sarahmonster commented 4 years ago

This adds the footer copyright line from the config file to the site footer:

Screenshot 2020-06-08 at 15 34 47

Fix #29.

@tofumatt Can you check to make sure I'm not doing anything I shouldn't really quickly? It looks like I've already merged this to master kinda accidentally, but I tried two approaches here to get the data—the first seemed more "correct", but it didn't work. 😞

sarahmonster commented 4 years ago

Oh yeah, I tried to do that, but I got an error about React hooks or something—see https://github.com/octopusthink/ghost-ship/pull/37/commits/d1fe6c5ac7d2852646ba860feb4dca032f4e8475

I'm guessing there's another way you're supposed to do it that I'm not doing?

tofumatt commented 4 years ago

That commit has you using the hook outside of the component which won't work. I moved it inside, but there are other config values being used and not available from the query so I'm fine just importing the JSON as-is here.

It's fine!