search

octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

feat: Show a leading icon for Danger, Warning, and Success buttons. #144

Closed sarahmonster closed 5 years ago

sarahmonster commented 5 years ago

Before

Screenshot 2019-07-11 at 18 16 47

After

Screenshot 2019-07-11 at 19 11 30

Fixes #142.

sarahmonster commented 5 years ago

Visually all the icons look a wee bit high, don't you think? Maybe it's just me.

Agreed! They should be inheriting a vertical-align property on the container span that will align them properly, but they aren't because of #127. Once we have a fix there, the icons should align properly here and elsewhere as well.