search

octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

feat: use CSS props and remove forwardRef #158

Closed tofumatt closed 5 years ago

tofumatt commented 5 years ago

Close #156.

This shouldn't change anything visually, but massively simplifies the code and component tree. The only real trade-off is having to create custom classNames for components like Paragraph for Heading to reference it (see: https://github.com/octopusthink/nautilus/blob/264de7a247529a8dd37de0a81399dee527d454ff/src/components/ui/Heading/index.js#L25).

tofumatt commented 5 years ago

(Right now this is failing a few tests, but I'm checking it out.)

tofumatt commented 5 years ago

This is now ready for a review/visual regression test. Eventually we'll automate that bit! 😅

tofumatt commented 5 years ago

Okay, those changes have been made; all set for another review!