search

octopusthink / nautilus

Inclusive, open-source design system and React component library.
https://nautilus.octopusthink.com
MIT License
2 stars 0 forks source link

Don't require Emotion as a dependency #188

Closed sarahmonster closed 4 years ago

sarahmonster commented 4 years ago

When trying to use Nautilus in a create-react-app app I was working on, I came across this error:

Screenshot 2019-11-13 at 04 03 02

I wasn't sure what was going on (I wasn't trying to use Emotion in the app yet, just to hook up Nautilus), but installing Emotion in my app solved the problem.

We should ideally not require Emotion as a dependency (since not everyone would want to use it), or, if it's strictly required, we should install it along with Nautilus itself. (I don't know if that's possible, but it feels like it should be!)

tofumatt commented 4 years ago

Or rather: we should explicitly require emotion as a dependency, because our components rely on it. I'll create a PR to address this, it's easy 😄